[16.0][ADD] hr_employee_firstname_partner_firstname. #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New glue module between hr_employee_firstname and partner_firstname. Correctly prepare employee value, when creating employee from user.
legalsylvain
changed the title
in hr_employee_lastnames, _update_partner_firstname function write on partner with the field 'lastname2'. This field is defined in a module that is not present in the dependency
legalsylvain
commented
Dec 17, 2024
| @@ -8,7 +8,7 @@ | |||
| "license": "AGPL-3", | |||
| "category": "Human Resources", | |||
| "summary": "Split Name in First Name, Father's Last Name and Mother's Last Name", | |||
| "depends": ["hr_employee_firstname"], | |||
| "depends": ["hr_employee_firstname", "partner_second_lastname"], | |||
There was a problem hiding this comment.
Note. This dependency was present in the beginning.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi. @OCA/human-resources-maintainers . could you take a look on this trivial PR ? |
dreispt
approved these changes
Apr 21, 2025
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found that hr_employee_firstname doesn't depend on partner_firstname. As a result, some error occures, specially when creating employee from user.
This glue module is fixing some points.